Add orderBy, first and last parameters to groupedAggregates #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjie
requested changes
Nov 5, 2025
There was a problem hiding this comment.
This is really thorough, I like it! I wonder how we avoid type explosion with this - perhaps we should have an opt-in to the feature? I don't think index behaviours can save us here. This plugin already adds a lot of types to the schema 😅
For now let's drop the last argument.
Comment on lines
+278
to
+282
| - `first` / `last` – slice the ordered groups, returning only the leading or | ||
| trailing `n` groups. | ||
|
|
||
| Always pair `first` or `last` with an explicit `orderBy` so PostgreSQL can | ||
| deterministically rank the groups before trimming them. |
There was a problem hiding this comment.
Suggest that we remove last - if they need that they should do the inverse order.
Comment on lines
+337
to
+338
| When using `last`, be sure to supply an `orderBy` so the database can produce a | ||
| deterministic ordering before the tail slice is applied. |
There was a problem hiding this comment.
We should default to ordering by the group by clauses; I didn't realise we didn't do that already.
Comment on lines
+20
to
+21
| orderBy: [SUM_POINTS_ASC] | ||
| last: 2 |
There was a problem hiding this comment.
Suggested change
| orderBy: [SUM_POINTS_ASC] | |
| last: 2 | |
| orderBy: [SUM_POINTS_ASC] | |
| first: 2 |
Comment on lines
+337
to
+339
| When using `last`, be sure to supply an `orderBy` so the database can produce a | ||
| deterministic ordering before the tail slice is applied. | ||
|
|
There was a problem hiding this comment.
Suggested change
| When using `last`, be sure to supply an `orderBy` so the database can produce a | |
| deterministic ordering before the tail slice is applied. |
Comment on lines
+46
to
+56
| exports[`GroupedAggregatesOrderBy: sql 1`] = ` | ||
| [ | ||
| "select | ||
| (coalesce(sum(__match_stats__."points"), '0'))::text as "0", | ||
| __match_stats__."player_id"::text as "1" | ||
| from "test"."match_stats" as __match_stats__ | ||
| group by __match_stats__."player_id" | ||
| order by coalesce(sum(__match_stats__."points"), '0') desc | ||
| limit 2;", | ||
| ] | ||
| `; |
There was a problem hiding this comment.
My understanding is that when switching to last with reverse ordering, it became the same exact query for the database and it was deduplicated so it was never executed.
Comment on lines
+199
to
+225
| last: { | ||
| type: build.graphql.GraphQLInt, | ||
| description: build.wrapDescription( | ||
| "Only include the last `n` grouped aggregates.", | ||
| "arg" | ||
| ), | ||
| applyPlan: EXPORTABLE( | ||
| () => | ||
| function ( | ||
| _$parent, | ||
| $pgSelect: PgSelectStep<any>, | ||
| arg | ||
| ) { | ||
| const selectAny = $pgSelect as any; | ||
| const originalAssert = | ||
| selectAny.assertCursorPaginationAllowed; | ||
| try { | ||
| selectAny.assertCursorPaginationAllowed = () => {}; | ||
| $pgSelect.setLast(arg.getRaw()); | ||
| } finally { | ||
| selectAny.assertCursorPaginationAllowed = | ||
| originalAssert; | ||
| } | ||
| }, | ||
| [] | ||
| ), | ||
| }, |
There was a problem hiding this comment.
Suggested change
| last: { | |
| type: build.graphql.GraphQLInt, | |
| description: build.wrapDescription( | |
| "Only include the last `n` grouped aggregates.", | |
| "arg" | |
| ), | |
| applyPlan: EXPORTABLE( | |
| () => | |
| function ( | |
| _$parent, | |
| $pgSelect: PgSelectStep<any>, | |
| arg | |
| ) { | |
| const selectAny = $pgSelect as any; | |
| const originalAssert = | |
| selectAny.assertCursorPaginationAllowed; | |
| try { | |
| selectAny.assertCursorPaginationAllowed = () => {}; | |
| $pgSelect.setLast(arg.getRaw()); | |
| } finally { | |
| selectAny.assertCursorPaginationAllowed = | |
| originalAssert; | |
| } | |
| }, | |
| [] | |
| ), | |
| }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More context on #75. Closes #75
Basically adds
orderBy,firstandlastparameters togroupedAggregates.orderByaccepts any possible field aggregations. Note that I still don't have a very good understanding of the project, this PR is party AI generated and partly from copy pasting various concepts around, would appreciate deep review from someone who understands the code better to see if there can better ways.Performance impact
Slight performance impact in startup time due to added(18 entries per numerical fields in AggregatesOrderBy enum)
Security impact
Shouldn't be.
Checklist
yarn lint:fixpasses. - I'm working on estlint to run properlyyarn testpasses.RELEASE_NOTES.mdfile (if one exists). - File doesn't exist